feat(core): clear up integrations on dispose#20407
Open
Conversation
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chargome
reviewed
Apr 21, 2026
JPeer264
force-pushed
the
jp/cloudflare-oom
branch
from
16defdb to
295ad22
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
There are 4 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 295ad22. Configure here.
s1gr1d
approved these changes
Apr 22, 2026
JPeer264
force-pushed
the
jp/cloudflare-oom
branch
from
295ad22 to
0886f8b
Compare
JPeer264
force-pushed
the
jp/cloudflare-oom
branch
from
0886f8b to
e945863
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #19573
closes JS-1829
As with Cloudflare we create a new client on every request, that means that every integration that uses an
addHandlerand is used by the Cloudflare SDK is makes the client not disposable - so the garbage collector can't remove it properly.This PR adds a callback for
addHandlerthat basically removes the handler from the global handler array (for now only for integrations, which are used by the Cloudflare SDK). I actually also tried to change the global handler to be aWeakMap, but it still showed some memory leaks with that, so we need to actively remove these callbacks.For now, to not increase the bundle sizes for core too much, it is actually removing the handlers only in the
ServerRuntimeClient, as for browsers it is usually not really an issue.