Skip to content

Fix repository url in package.json #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosriady merged 3 commits into from
May 3, 2026
Merged

Fix repository url in package.json #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e1a213
Add release workflow
yosriady May 3, 2026
ddba2be
Pin pnpm version via packageManager field
yosriady May 3, 2026
fe9f15b
Add repository metadata for npm provenance
yosriady May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: CLI CI
name: Formo CLI CI Check

on:
pull_request:
Expand All @@ -17,71 +17,65 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4.0.0
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Setup pnpm
uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
with:
version: 10

- name: Setup Node
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v4.3.0
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: "22.14.0"
cache: 'pnpm'

- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Build
- name: Build CLI
run: pnpm build

lint:
runs-on: ubuntu-latest
needs: build
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4.0.0
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Setup pnpm
uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
with:
version: 10

- name: Setup Node
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v4.3.0
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: "22.14.0"
cache: 'pnpm'

- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Lint
- name: Run lint
run: pnpm lint

test:
runs-on: ubuntu-latest
needs: [build, lint]
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4.0.0
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Setup pnpm
uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
with:
version: 10

- name: Setup Node
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v4.3.0
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: "22.14.0"
cache: 'pnpm'

- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Test
- name: Run tests
run: pnpm test
env:
TEST_TOKEN: ${{ secrets.TEST_TOKEN }}
21 changes: 11 additions & 10 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ on:
- 'v*'

permissions:
id-token: write # Required for npm provenance attestation
id-token: write # Required for OIDC trusted publishing
contents: write # Required for creating GitHub releases

jobs:
publish:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4.0.0
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0

Expand All @@ -29,15 +29,16 @@ jobs:

- name: Setup pnpm
uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
with:
version: 10

- name: Setup Node
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v4.3.0
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: "22.14.0"
cache: 'pnpm'
registry-url: 'https://registry.npmjs.org'
# No registry-url - using OIDC trusted publishing instead

- name: Update npm for trusted publishing
run: npm install -g npm@latest

- name: Install dependencies
run: pnpm install --frozen-lockfile
Expand Down Expand Up @@ -68,9 +69,9 @@ jobs:
TEST_TOKEN: ${{ secrets.TEST_TOKEN }}

- name: Publish to npm
run: npm publish --access public --provenance
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
run: npm publish --provenance
# Explicitly use --provenance flag for clarity
# OIDC trusted publishing (id-token: write) enables automatic provenance generation

- name: Generate release notes
id: release_notes
Expand Down Expand Up @@ -158,7 +159,7 @@ jobs:
EOF

- name: Create GitHub Release
uses: softprops/action-gh-release@153bb8e04406b158c6c84fc1615b65b24149a1fe # v2.6.1
uses: softprops/action-gh-release@b4309332981a82ec1c5618f44dd2e27cc8bfbfda # v3.0.0
with:
body_path: release_notes.md
draft: false
Expand Down
9 changes: 9 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
{
"name": "@formo/cli",
"version": "0.2.0",
"packageManager": "pnpm@10.28.2",

@gemini-code-assist gemini-code-assist Bot May 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version 10.28.2 for pnpm appears to be a typo. pnpm 10 is a very recent major version and likely has not reached such a high patch number yet. An invalid version in the packageManager field will cause corepack to fail when attempting to prepare the environment. Please verify the intended version (e.g., 9.15.4 or 10.0.0).

Suggested change
"packageManager": "pnpm@10.28.2",
"packageManager": "pnpm@10.0.0",

"description": "Formo API CLI — query profiles and analytics data",
"repository": {
"type": "git",
"url": "git+https://github.com/getformo/cli.git"
},
"homepage": "https://github.com/getformo/cli#readme",
"bugs": {
"url": "https://github.com/getformo/cli/issues"
},
Comment on lines +6 to +13

@gemini-code-assist gemini-code-assist Bot May 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For GitHub-hosted repositories, you can simplify the repository field using the shorthand syntax. Additionally, since the homepage and bugs URLs follow the standard GitHub pattern, they can be automatically inferred by npm, allowing you to remove these redundant fields and keep the package.json cleaner.

  "repository": "getformo/cli",

"bin": {
"formo": "dist/index.js"
},
Expand Down