Skip to content

#12553: Fix - WMC export fails when maxExtent is undefined#12554

Merged
offtherailz merged 3 commits into
geosolutions-it:masterfrom
dsuren1:#12553_fix
Jun 29, 2026
Merged

#12553: Fix - WMC export fails when maxExtent is undefined#12554
offtherailz merged 3 commits into
geosolutions-it:masterfrom
dsuren1:#12553_fix

Conversation

@dsuren1

@dsuren1 dsuren1 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes the WMC export when maxExtent is undefined

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?
WMC export works even when maxExtent is undefined and the same works even on saved map with this map configuration

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added this to the 2026.02.00 milestone Jun 26, 2026
@dsuren1 dsuren1 requested a review from offtherailz June 26, 2026 12:34
@dsuren1 dsuren1 added the bug label Jun 26, 2026
@cla-bot cla-bot Bot added the CLA Ready label Jun 26, 2026
@dsuren1 dsuren1 linked an issue Jun 26, 2026 that may be closed by this pull request
1 task

@offtherailz offtherailz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that the bbox should come, because it is mandatory.
The problem generated is due to the missing bbox of the current map, and so the error should be resolved.
The function should not generate an invalid WMC but rise an error, while MapStore should never generate from the current map a WMC without the current bbox.

@dsuren1 dsuren1 requested a review from offtherailz June 29, 2026 08:11
Comment thread web/client/utils/ogc/__tests__/WMC-test.js Outdated
@dsuren1 dsuren1 requested a review from offtherailz June 29, 2026 13:45

@offtherailz offtherailz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@offtherailz offtherailz merged commit 1fb07d0 into geosolutions-it:master Jun 29, 2026
12 checks passed
@offtherailz

Copy link
Copy Markdown
Member

Successfully created backport PR for 2026.02.xx:

@offtherailz

Copy link
Copy Markdown
Member

@ElenaGallo please get in sync with @dsuren1 about how to test this PR

offtherailz added a commit that referenced this pull request Jun 29, 2026
…12561)

* 12553: Fix - WMC export fails when maxExtent is undefined

* updated unit tests

* Apply suggestion from @offtherailz

---------


(cherry picked from commit 1fb07d0)

Co-authored-by: Suren <dsuren1@gmail.com>
tdipisa pushed a commit that referenced this pull request Jul 2, 2026
…12561) (#12569)

Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WMC export fails when maxExtent is undefined

2 participants