Skip to content

#12467 Add maximum visible features in current view option for FlatGeobuf layers (Implement Design Change Feedback)#12552

Merged
dsuren1 merged 2 commits into
geosolutions-it:masterfrom
Binabh:fix/maxFeatures-long-placeholder-issue
Jun 30, 2026
Merged

#12467 Add maximum visible features in current view option for FlatGeobuf layers (Implement Design Change Feedback)#12552
dsuren1 merged 2 commits into
geosolutions-it:masterfrom
Binabh:fix/maxFeatures-long-placeholder-issue

Conversation

@Binabh

@Binabh Binabh commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

Design change to use tooltip instead of placeholder as clarification text is too long.
Feedback here

Also added test to ensure that tooltip is there and updated translation keys for better clarity.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix/Design Change

Issue

What is the current behavior?

#12467 (comment)

What is the new behavior?
Uses tooltip instead of placeholder

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

@Binabh Binabh added this to the 2026.02.00 milestone Jun 26, 2026
@Binabh Binabh requested a review from allyoucanmap June 26, 2026 11:23
@cla-bot cla-bot Bot added the CLA Ready label Jun 26, 2026
@Binabh Binabh linked an issue Jun 26, 2026 that may be closed by this pull request
Add maximum visible features in current view option for FlatGeobuf layers #12467
Open
6 tasks
@Binabh Binabh changed the title Add maximum visible features in current view option for FlatGeobuf layers #12467 #12467 Add maximum visible features in current view option for FlatGeobuf layers (Inplement Design Change Feedback) Jun 26, 2026
@Binabh Binabh changed the title #12467 Add maximum visible features in current view option for FlatGeobuf layers (Inplement Design Change Feedback) #12467 Add maximum visible features in current view option for FlatGeobuf layers (Implement Design Change Feedback) Jun 26, 2026
@tdipisa tdipisa requested review from dsuren1 and removed request for allyoucanmap June 29, 2026 16:10
@tdipisa tdipisa assigned dsuren1 and unassigned allyoucanmap Jun 29, 2026
dsuren1
dsuren1 approved these changes Jun 30, 2026
View reviewed changes

@dsuren1 dsuren1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsuren1 dsuren1 merged commit fa73e48 into geosolutions-it:master Jun 30, 2026
13 checks passed
@dsuren1

dsuren1 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@ElenaGallo Kindly test this in DEV when available. Thanks!

@offtherailz offtherailz mentioned this pull request Jun 30, 2026
Merged
@offtherailz

offtherailz commented Jun 30, 2026

Copy link
Copy Markdown
Member

Successfully created backport PR for 2026.02.xx:

offtherailz added a commit that referenced this pull request Jun 30, 2026
@offtherailz @Binabh
fix: use max features in view tooltip instead of placeholder and upda…
50fca63 
…te related tests (#12552) (#12564)

(cherry picked from commit fa73e48)

Co-authored-by: Binabh <binabhdevkota@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsuren1 dsuren1 dsuren1 approved these changes

Assignees

@dsuren1 dsuren1

Labels

backport 2026.02.xx CLA Ready

Projects

None yet

Milestone

2026.02.00

Development

Successfully merging this pull request may close these issues.

Add maximum visible features in current view option for FlatGeobuf layers

5 participants

@Binabh @dsuren1 @offtherailz @tdipisa @allyoucanmap