Remove es5.js and browser check from html files#12494
Open
jna4k wants to merge 1 commit into
Open
Conversation
4defdf7 to
bd137d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the es5.js file that was being loaded from a external CDN. It also removes a browser check that redirected the user to the "unsupported browser page" if the user were using a browser other than chrome, firefox, edge or safari. The PR also removes said unspported browser page.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
We are currently using a 3rd party javascript file from a CDN, and uses it to check the users browser version, if the user is using Internet Explore they will be redirected to a unsupported browser page.
#12477
What is the new behavior?
We will no longer load the es5.js file and the we will no longer do the browser check. This means if the user is using a unspported browser, the site will simply fail.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information