Skip to content

#13460 - image edit button unresponsive after saving image edit changes#74

Open
Zeljko-Predjeskovic wants to merge 1 commit into
developfrom
fix/13460-Nullreference-and-save-tool-states
Open

#13460 - image edit button unresponsive after saving image edit changes#74
Zeljko-Predjeskovic wants to merge 1 commit into
developfrom
fix/13460-Nullreference-and-save-tool-states

Conversation

@Zeljko-Predjeskovic

Copy link
Copy Markdown
Collaborator

#13459 - image edit - pin size is not saved

@Zeljko-Predjeskovic

Copy link
Copy Markdown
Collaborator Author

Test not working yet

@gentledepp gentledepp left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review focusing on soundness, design, IDisposable/Rx correctness, unawaited tasks, and test coverage. I ran the new test suites against this branch locally (not just read them) to verify the test-coverage claims below.

Comment thread Svg.Editor.Core.Tests/PinToolTests.cs
Comment thread Svg.Editor.Core.Tests/PinInputServiceTests.cs
Comment thread Svg.Editor.Core.Tests/PinToolTests.cs
Comment thread Svg.Editor.Avalonia.Forms/Dialog/Views/ActionSheetDialogViewModel.cs Outdated
Comment thread Svg/Extensions.cs
Comment thread Svg.Editor.Core.Tests/PinToolTests.cs Outdated
@Zeljko-Predjeskovic Zeljko-Predjeskovic force-pushed the fix/13460-Nullreference-and-save-tool-states branch 2 times, most recently from 76aa643 to 887821f Compare July 9, 2026 08:05
@Zeljko-Predjeskovic Zeljko-Predjeskovic force-pushed the fix/13460-Nullreference-and-save-tool-states branch from 887821f to ead4da6 Compare July 9, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants