Skip to content

Trigger node deletion when machine is deleted#1102

Open
gagan16k wants to merge 1 commit into
gardener:masterfrom
gagan16k:fix/machine-delete
Open

Trigger node deletion when machine is deleted#1102
gagan16k wants to merge 1 commit into
gardener:masterfrom
gagan16k:fix/machine-delete

Conversation

@gagan16k
Copy link
Copy Markdown
Member

What this PR does / why we need it:

  1. Machine controller now explicitly deletes the backing node from the target cluster on machine delete events, and removes finalizers from nodes that are being deleted with no backing machine.
  2. The machine status description during creation has been updated from "Creating machine on cloud provider" to "Creating machine on cloud provider. Waiting for node object to register", so the status accurately reflects which stage the machine is in.

Which issue(s) this PR fixes:
Fixes #1044, #1064

Release note:

MCM now deletes the backing node when its machine is force-deleted, and clears finalizers on nodes terminating without a backing machine. The machine creation status is also modified to distinguish cloud-provider failures from node-registration failures.

@gagan16k gagan16k requested a review from a team as a code owner May 18, 2026 12:33
@gardener-prow gardener-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 18, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ashwani2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels May 18, 2026
@aaronfern aaronfern added the kind/bug Bug label May 22, 2026
@gardener-prow gardener-prow Bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCM should always delete Node if corresponding Machine object is not present during termination flow

2 participants