Unify screen layout with KMP template#32
Open
Syntey wants to merge 6 commits into
Open
Conversation
matejsemancik
approved these changes
Jun 15, 2026
matejsemancik
left a comment
matejsemancik
left a comment
Member
There was a problem hiding this comment.
One nitpick - is the predictive back gesture adjustable? Currently feels rather slow when combined with fade-out. The KMP template uses material3 one and it matches the latest system ones better.
| override fun onSignIn() { | ||
| setUserLoggedInUseCase.execute(SetUserLoggedInUseCase.Args(isLoggedIn = true)) { | ||
| onSuccess { sendEvent(NavigateToHomeEvent) } | ||
| onSuccess { sendEvent(NavigateToFirstEvent) } |
Member
There was a problem hiding this comment.
Just an idea - can we inject NavRouter instance into ViewModel and get rid of event-based navigation? NavRouter is an interface, so could be easily faked in unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.