Conversation
…yAsync - Add SideEffects module to TaskSeq.ChunkBy.Tests.fs with TestSideEffectTaskSeq variant tests for chunkBy and chunkByAsync - Test that each projection is called exactly once per element - Test that the source is not evaluated before enumeration - Add two more TestImmTaskSeq variant tests (each-element-own-chunk, chunkByAsync) Total new test cases: +121 (grows from ~11 scenarios to 170 xUnit test runs with variants) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8 tasks
dsyme
approved these changes
Apr 20, 2026
…0-7b06bb767b100bf2
dsyme
deleted the
repo-assist/test-chunkby-sideeffects-20260420-7b06bb767b100bf2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant.
Summary
TaskSeq.ChunkBy.Tests.fspreviously had only 11 test scenarios (all inEmptySeqandFunctionalitymodules). This PR adds aSideEffectsmodule and two additionalTestImmTaskSeqvariant tests, matching the coverage pattern used by other test files likeTaskSeq.SplitAt.Tests.fsandTaskSeq.DistinctUntilChanged.Tests.fs.New tests added
SideEffectsmodule (6 new scenarios):TestSideEffectTaskSeqvariant:chunkBygroups all side-effect-seq elements into one chunk under a constant keyTestSideEffectTaskSeqvariant:chunkByAsyncgroups all side-effect-seq elements into one chunkTestSideEffectTaskSeqvariant:chunkBy idproduces 10 singleton chunks from the side-effect seqchunkBy)chunkByAsync)Additional
Functionalitytests (3 new scenarios × variants):TestImmTaskSeq: each element in its own chunk (viaidprojection)TestImmTaskSeq:chunkByAsyncgroups all elements under one keyTest growth
Test Status
dotnet build -c Release— succeeded (0 warnings, 0 errors)dotnet test -c Release— 5223 passed, 2 skipped (pre-existing infrastructure skips)dotnet fantomas . --check— passed