Skip to content

fix one off gathering#614

Open
TuysuzTavsan wants to merge 1 commit into
foxssake:mainfrom
TuysuzTavsan:fix-one-off-input-recording
Open

fix one off gathering#614
TuysuzTavsan wants to merge 1 commit into
foxssake:mainfrom
TuysuzTavsan:fix-one-off-input-recording

Conversation

@TuysuzTavsan

Copy link
Copy Markdown
Contributor

commit d6ddde4 broke the one off input gathering.

One off inputs are recorded on NetworkTİme.after_tick.
Before that* commit rollback inputs were recorded from rbs after_tick.
After that commit rollback inputs are recorded from network-rollback after_tick.

Godot calls signals based on their connected order.
Before server update rbs's were connecting their signals with a deferred call. This was resulting in one off input node winning the race. But after the server update, since servers are initialized before anything else, input nodes are always losing the race.

This pr fixes the race condition by introducing gather_one_off_inputs signal on NetworkRollback. Signal is emitted just before recording/synchronizing inputs.

Docs are updated with 1 note
Examples using gather_always changed to use this new signal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant