fod sast-scan start: add --in-progress-action and --entitlement-preference options, fix NPE#1032
Closed
Copilot wants to merge 3 commits into
Closed
fod sast-scan start: add --in-progress-action and --entitlement-preference options, fix NPE#1032Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
…-entitlement-preference options with ftests
…ng in startScanAdvanced
Copilot
AI
changed the title
[WIP] Fix code for all comments in review thread
fod sast-scan start: add --in-progress-action and --entitlement-preference options, fix NPE
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two review comments on PR #1015: a potential
NullPointerExceptionon theremediationScanTypemixin field, and missing functional test coverage for the new advanced-scan code paths.Changes
FoDSastScanStartCommand--in-progress-action(InProgressScanActionType) and--entitlement-preference(EntitlementPreferenceType) optionsstartScanAdvancedwhen either new option is supplied; falls back tostartScanWithDefaultsotherwise (backward-compatible)remediationScanTypeagainstnullbefore dereferencing —@Mixinfields are not guaranteed to be injected:CancelScanInProgress→"CancelInProgressScan"at the SAST command boundary (FoD'sstart-scan-advancedrejects the enum name);Queueis the default when the advanced path is taken without an explicit--in-progress-actionFoDScanSastHelper.startScanAdvancedinProgressScanActionTypeas a raw string rather than throughvalueOf(), since the translated wire valueCancelInProgressScanis not a valid enum name; added a comment explaining the intentional asymmetry with the other parametersFoDMessages.propertiesfcli.fod.sast-scan.start.in-progress-actiondescription with completion candidatesFoDScanSpec(ftest)start.sast-scan-advanced-queue: exercises the advanced endpoint with--in-progress-action=Queuestart.sast-scan-advanced-entitlement-preference: exercises the advanced endpoint with--entitlement-preference=SubscriptionOnly(implicitly defaults--in-progress-actiontoQueue)