Added support for multiple executors per language#83
Open
callamaris wants to merge 2 commits intoformulahendry:masterfrom
callamaris:multiple-executor-maps
Open
Added support for multiple executors per language#83callamaris wants to merge 2 commits intoformulahendry:masterfrom callamaris:multiple-executor-maps
callamaris wants to merge 2 commits intoformulahendry:masterfrom
callamaris:multiple-executor-maps
Conversation
| private getExecutor(languageId: string, fileExtension: string): string { | ||
| private async getSubExecutor(executor: any): Promise<string> { | ||
| let subExecutorId = await vscode.window.showQuickPick(Object.keys(executor), { placeHolder: "Type or select command to run" }); | ||
| if (subExecutorId !== undefined) { |
Owner
There was a problem hiding this comment.
Need to handle the case when subExecutorId is undefined (user does not select command to run)
| let fileExtension = this.getFileExtension(editor); | ||
| let executor = this.getExecutor(languageId, fileExtension); | ||
|
|
||
| //multiple commands per executor |
Owner
There was a problem hiding this comment.
Add space --> // multiple ...
space added to comment
| if (subExecutorId !== undefined) { | ||
| executor = executor[subExecutorId]; | ||
| } else { | ||
| executor = null; |
Owner
There was a problem hiding this comment.
Just return null is not good experience for users. It will lead to vscode.window.showInformationMessage('Code language not supported or defined.'); be called.
formulahendry
requested changes
Mar 3, 2017
Owner
formulahendry
left a comment
formulahendry
left a comment
There was a problem hiding this comment.
exit run function if subExecutorId is undefined. Avoid calling vscode.window.showInformationMessage('Code language not supported or defined.');
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
i have added some basic support for multiple executor maps per language.
The pre-selection of previously used commands needs some more investigation.
#48