Update of sorting, reformatting and missing things#69
Open
ElektroStudios wants to merge 6 commits intoformulahendry:masterfrom
Open
Update of sorting, reformatting and missing things#69ElektroStudios wants to merge 6 commits intoformulahendry:masterfrom
ElektroStudios wants to merge 6 commits intoformulahendry:masterfrom
Conversation
## FIELDS/PROPERTIES
- description:
- Language names were alphabetically sorted.
- version:
- Changed to "0.6.8"
- keywords:
- Language names were alphabetically sorted.
- code-runner.executorMap:
- Language names were alphabetically sorted.
- Added missing supported languages (Elixir, VB.NET)
- Language names simplified and reformatted.
- Some comments for the author about the major changes I did:
- "JS" was the name that for legally issues Microsoft's choosed for their JavaScript for Windows version, which is exactlly the same as the "common" JavaScript, but the name "JS" only reffers to the Microsoft JavaScript version, and that was very confussing.
- All the other major name changes I've explained the reasons in the request I did: formulahendry#64
- Command syntaxes/paths simplified.
- Added commands for C# and VB.NET. compilation
- Changed node.exe in JavaScript for Cscript.exe (a.k.a Windows Script Host). I just think it is better to set by default a native installed executable of the Windows O.S.
- code-runner.executorMapByFileExtension:
- File extensions were alphabetically sorted.
- Added lots of missing file extensions with their corresponding commands.
- code-runner.customCommand
- Changed the default command "Echo Hello" for "Echo Hello World!" which is a more familiar thing in the programming world .
- code-runner.languageIdToFileExtensionMap
- Added somre mappings.
## SETTINGS
- code-runner.saveFileBeforeRun
- Changed from "false" to "true", as the behavior of an IDE. Really has no sense to run/compile a file with unsaved changes, it was redundant.
## COMMANDS
- "code-runner.run" has been renamed to "code-runner.runCode"
- "code-runner.runByLanguage" has been renamed to "code-runner.runCodeByLanguage"
Then commands were sorted alphabetically in package.json, codeManager.json and extension.json files (in arrays, and function names/blocks).
| "code-runner.executorMap": { | ||
| "type": "object", | ||
| "default": { | ||
| "AppleScript": "osascript.exe", |
Owner
There was a problem hiding this comment.
Do not change the id list, they come from the Language Identifiers
| "code-runner.executorMap": { | ||
| "type": "object", | ||
| "default": { | ||
| "AppleScript": "osascript.exe", |
Owner
There was a problem hiding this comment.
We are supporting Windows as well as Linux and macOS. So we could not use *.exe
| "code-runner.executorMapByFileExtension": { | ||
| "type": "object", | ||
| "default": { | ||
| ".bat": "CMD.exe /C", |
Owner
There was a problem hiding this comment.
No need to add executor for each file extension. It is what Language Identifiers need to do.
| "code-runner.languageIdToFileExtensionMap": { | ||
| "type": "object", | ||
| "default": { | ||
| "Batch File": [".bat", ".cmd"], |
formulahendry
requested changes
Feb 3, 2017
Owner
formulahendry
left a comment
formulahendry
left a comment
There was a problem hiding this comment.
I suggest you go through all the code logic and make sure there would not be any regression. 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIELDS/PROPERTIES
description:
version:
keywords:
code-runner.executorMap:
code-runner.executorMapByFileExtension:
code-runner.customCommand
code-runner.languageIdToFileExtensionMap
SETTINGS
COMMANDS
"code-runner.run" has been renamed to "code-runner.runCode"
"code-runner.runByLanguage" has been renamed to "code-runner.runCodeByLanguage"
Then commands were sorted alphabetically in package.json, codeManager.json and extension.json files (in arrays, and function names/blocks).