Skip to content

Potential fixes for 2 code quality findings#180

Closed
66Ton99 wants to merge 2 commits into
masterfrom
ai-findings-autofix/src-Resources-public-js-constraints-Url.test.js
Closed

Potential fixes for 2 code quality findings#180
66Ton99 wants to merge 2 commits into
masterfrom
ai-findings-autofix/src-Resources-public-js-constraints-Url.test.js

Conversation

@66Ton99
Copy link
Copy Markdown
Collaborator

@66Ton99 66Ton99 commented Jun 4, 2026

This PR applies 2/2 suggestions from code quality AI findings.

66Ton99 and others added 2 commits June 4, 2026 20:20
…s from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…s from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@66Ton99 66Ton99 closed this Jun 5, 2026
@66Ton99
Copy link
Copy Markdown
Collaborator Author

66Ton99 commented Jun 5, 2026

Closing this draft AI autofix as outdated and not needed for the current branch.

The proposed change only updates Url.test.js, but one of the suggested expected values no longer matches the current validator behavior: for http://a, the implementation still formats the failing value as http://http://a. The PR also predates the current Symfony 8 / renewed CI baseline and has a failing JavaScript/browser check.

If we want to change URL normalization behavior, it should be handled as a focused code+test change rather than keeping this generated draft open.

@66Ton99 66Ton99 deleted the ai-findings-autofix/src-Resources-public-js-constraints-Url.test.js branch June 5, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant