[codex] Support error path mapping#178
Merged
Merged
Conversation
Introduce FpJsFormError so custom constraints can return structured errors with an atPath value. Resolve the path from the validated element and route the error message to the matching child element, with fallback to the validated element when the path is unknown. Keep existing string-returning constraints backward-compatible by converting strings to FpJsFormError during validation. Clear the current validation source recursively before each validation pass so routed errors disappear after the constraint becomes valid. Document the custom constraint API and cover direct, nested, fallback, string-error, revalidation, and model-only DOM cases in Jest. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes the useful behavior from #113 with a small modern patch against the current codebase.
Plan
atPath()behavior.Changes
FpJsFormError(message)with optionalatPath.FpJsFormErrorduring validation.src/Resources/doc/3_2.md.Tests
npm run test:unit -- FpJsFormValidator.test.js --runInBandphp /tmp/jsfv-composer.phar validate --strictphp /tmp/jsfv-composer.phar testnpm testgit diff --check