[codex] Preserve native submit events#176
Merged
66Ton99 merged 1 commit intoJun 4, 2026
Merged
Conversation
Port the intent of old PR formapro#131 onto the modern validator without allowing forms to submit before asynchronous validation completes. Let synchronous valid native submit events continue instead of replacing them with form.submit(), so the browser preserves the original submitter button. Keep invalid native submits prevented, keep programmatic submits working, and re-submit async-valid native events through requestSubmit(event.submitter) with a guard to avoid revalidating the re-submitted event. Add Jest regression coverage for valid, invalid, async, and guarded re-submitted submit flows. Validation: php /tmp/jsfv-composer.phar validate --strict; php /tmp/jsfv-composer.phar test; npm test; git diff --check. Co-authored-by: Codex <codex@openai.com>
66Ton99
force-pushed
the
codex/pr131-preserve-submit-event
branch
from
9228d15 to
4b21eb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
form.submit().requestSubmit(event.submitter)when available.Why
Calling
form.submit()after every successful native submit loses browser submitter context, including the clicked submit button. The old PR avoided that by not preventing valid native submissions, but it also risked allowing submission before asynchronous validation finished. This version keeps the safe async behavior while preserving the original submitter when the browser supportsrequestSubmit().Validation
php /tmp/jsfv-composer.phar validate --strictphp /tmp/jsfv-composer.phar testnpm testgit diff --check