Skip to content

OKAPI-1248: Use GitHub Actions Workflows for Maven replacing Jenkinsfile#1450

Open
julianladisch wants to merge 6 commits into
masterfrom
OKAPI-1248
Open

OKAPI-1248: Use GitHub Actions Workflows for Maven replacing Jenkinsfile#1450
julianladisch wants to merge 6 commits into
masterfrom
OKAPI-1248

Conversation

@julianladisch

Copy link
Copy Markdown
Contributor

@julianladisch julianladisch requested a review from a team June 10, 2026 15:05
@dcrossleyau dcrossleyau self-requested a review June 11, 2026 01:53

@dcrossleyau dcrossleyau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent Julian, thanks for sorting this out.

I tried adding the "docker-health-command" as was done in the old Jenkinsfile, but that build-and-test failed. So removed it.
Maybe you know what is happening there.

I do not know what is wrong with the Sonar thing, but that should not hold up merging this.

The other jobs are okay.

If you need help with the branch protection configuration then i can assist.

@julianladisch

Copy link
Copy Markdown
Contributor Author

Okapi needs runArgs = 'dev' for the docker-health-command.

We test the Docker container in the OkapiIT.java integration test instead.

Thank you for fixing the maven.yml and adding the docker-label-documentation.

@dcrossleyau

Copy link
Copy Markdown
Contributor

Jason fixed the weird Sonar problem. It wanted the project key changed at the Sonar end.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants