You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We use Vlasiator-version of DCCRG which has diverged quite a bit, and probably won't be refactored together in the foreseeable future. So fixes should at least be made as PR's to that branch (thought I guess this can also be left for Ilja to consider!)
Hi @markusbattarbee,
As this "bug" is also present in the main branch I suspected it to be of interest for both versions.
If you want, i can just submit another PR targeting the vlasiator-version?
Well, I can't actually find the dimension-specific x/y/z_indices_overlap() functions in the Vlasiator-version branch at all, so I do somewhat wonder how you encountered this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #57.
I did test it in a Vlasiator installation i am doing and there applying these changes makes it compile with LLVM 19.
I didn't do a proper check if it semantically correct. I just went ahead and assumed that
Types<3>::indices_thas the indicesstores as
[x,y,z].If you need some changes just let me know :)