Skip to content

Cleanup of main entry script#11

Merged
spurnvoj merged 8 commits into
ros2from
check_before_installing_git
Jun 2, 2026
Merged

Cleanup of main entry script#11
spurnvoj merged 8 commits into
ros2from
check_before_installing_git

Conversation

@vidvidex
Copy link
Copy Markdown
Collaborator

@vidvidex vidvidex commented Jun 1, 2026

Reformat of main entry files and a check if git is installed before attempting to install it

@spurnvoj
Copy link
Copy Markdown
Member

spurnvoj commented Jun 1, 2026

@vidvidex I compared the f4f and mrs installation scripts, and they are almost identical. I would say that f4f is more up to date because it runs "sudo apt update" before installing any packages. Wouldn’t it make more sense to have a single script that lets the user choose which configuration to use?

vidvidex and others added 4 commits June 2, 2026 08:49
* Fix netplan config script to work when there is no eth or wlan interfaces

Before it would always append
    ethernets:
or
    wifis:
to the config file, even if there are such interfaces found, resulting in a syntax error when applying

* Disable network manager immediately when configuring networking

* Install netplan if not installed yet

* Copilot fixes

* Migrate to newer default gateway syntax

gateway4 is deprecated

* Reformat

* Add default gateway prompt for eth

* Ensure netplan config file has correct permissions

* Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Ask for DNS server on eth

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
As written in the wiki. The script only deletes empty directories (to prevent accidentally deleting important files)
@vidvidex vidvidex changed the title Check before installing git Cleanup of main entry script Jun 2, 2026
@vidvidex
Copy link
Copy Markdown
Collaborator Author

vidvidex commented Jun 2, 2026

New changes:

  • combined setup_utility_f4f.sh and setup_utility_mrs.sh into a single script. It asks which defaults you want to use when you run it
  • added a check when apt update was last ran and if it was recently (last hour) then don't run it again. This makes repeated use of the script much faster, since you don't have to wait for apt every time.

@spurnvoj spurnvoj merged commit 1071b3e into ros2 Jun 2, 2026
@spurnvoj spurnvoj deleted the check_before_installing_git branch June 2, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants