Dispose Animation Controller in Flutter for Android Devs Examples#13512
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds proper controller disposal by implementing the dispose() method in two state classes within the Android developers guide. However, these changes were made directly in the markdown file, which uses the code-excerpt tool to inject code from external Dart files. To prevent these updates from being overwritten, they must be applied directly to the source Dart files (animation.dart and events.dart) instead.
|
/gcbrun |
|
Staged preview of the updated docs.flutter.dev site (updated for commit d52aeba): https://flutter-docs-prod--docs-pr13512-patch-1-nk6l87xm.web.app |
|
Staged preview of the updated flutter.dev site (updated for commit d52aeba): https://flutter-dev-230821--www-pr13512-patch-1-agame43w.web.app |
|
Updated the code excerpts per the CI suggestion |
|
/gcbrun |
3 participants
Description of what this PR is changing or adding, and why:
Animation Controller examples in the Android Dev section were missing dispose logic for the controller lifecycle.
This PR adds this logic to the examples.
Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.