[camera_avfoundation] Move camera_avfoundation to Darwin#11847
[camera_avfoundation] Move camera_avfoundation to Darwin#11847Mairramer wants to merge 6 commits into
Conversation
…tep1-darwin-rename # Conflicts: # packages/camera/camera_avfoundation/pigeons/messages.dart
There was a problem hiding this comment.
Code Review
This pull request moves the camera_avfoundation package source files to a shared Darwin directory. It updates the Pigeon Swift output path to the new darwin directory, adds sharedDarwinSource: true to the iOS plugin configuration in pubspec.yaml, and documents the change in the changelog. There are no review comments, and I have no feedback to provide.
|
Maybe we should move the tests as well? |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Maybe we should move the tests as well?
Yes, native unit tests that would be shared should move to darwin/Tests/, and the Xcode project updated to reference the files there, as with other plugins in the repo that use shared source.
Done. |
There was a problem hiding this comment.
What is this for? I wouldn't expect us to need this folder to exist.
This PR moves the
camera_avfoundationplugin implementation to Darwin, aiming to consolidate the shared AVFoundation codebase for both iOS and macOS platforms.Part of flutter/flutter#41708
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2