Skip to content

FEAT: Warn on unknown keys in config file#1613

Open
syu-toutousai wants to merge 1 commit into
floatpane:masterfrom
syu-toutousai:master
Open

FEAT: Warn on unknown keys in config file#1613
syu-toutousai wants to merge 1 commit into
floatpane:masterfrom
syu-toutousai:master

Conversation

@syu-toutousai

@syu-toutousai syu-toutousai commented Jun 23, 2026

Copy link
Copy Markdown

Emit a warning at startup listing unrecognized config keys, helping users catch typos or stale keys early.

  • Added warnUnknownConfigKeys function that decodes top-level JSON keys and logs warnings for unknown ones
  • The function efficiently parses only the top-level keys using json.RawMessage to avoid deep parsing

---Payment info---
PayPal: n6085530@gmail.com

@syu-toutousai syu-toutousai requested a review from a team as a code owner June 23, 2026 01:23
@floatpanebot floatpanebot added the area/config Configuration / settings label Jun 23, 2026

@floatpanebot floatpanebot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @syu-toutousai! Please fix the following issues with your PR:

  • Title: Does not follow conventional commits (e.g., feat: added something, fix(core): resolved crash).
  • Title: Is too long (41 characters). The PR title must be strictly under 40 characters.
  • Body: Missing the ## What? or ## Why? headings required by the PR template.

@floatpanebot floatpanebot added bug Something isn't working size/M Diff: 51–200 lines labels Jun 23, 2026
@andrinoff

Copy link
Copy Markdown
Member

AI

@andrinoff andrinoff closed this Jun 23, 2026

@floatpanebot floatpanebot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrinoff! Please fix the following issues with your PR:

  • Title: Does not follow conventional commits (e.g., feat: added something, fix(core): resolved crash).
  • Title: Is too long (41 characters). The PR title must be strictly under 40 characters.
  • Body: Missing the ## What? or ## Why? headings required by the PR template.

@andrinoff andrinoff reopened this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Configuration / settings bug Something isn't working size/M Diff: 51–200 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants