feat: open HTML emails in browser#1609
Open
Shabhareash wants to merge 3 commits into
Open
Conversation
Member
Benchmark report — no significant changeMetrics worse: 0 · better: 0 (threshold: ±3%). benchstat outputauto-generated by benchmarks.yml |
19faec5 to
bb26d4e
Compare
Member
|
@Shabhareash sorry, this issue is a duplicate. This feature already is in v1 #1501 |
Author
|
Sorry for the multiple CI runs. This is my first issue on such a repo and i had some trouble with the linting tools. |
Member
|
I'd love to see you contribute into matcha. Please note, that we currently only implement features to v1 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Added a new action to open HTML emails in the default browser. When viewing an HTML email, users can now press
oto write the HTML body to a temporary file and open it in their system's default browser (usingopenon macOS,xdg-openon Linux, andcmd /c starton Windows).Changes:
OpenHTMLBrowserkeybinding (default:o) toconfig/keybinds.goandconfig/default_keybinds.jsonOpenHTMLEmailMsgmessage type totui/messages.gotui/email_view.goto emit the message when pressingoon HTML emails, with updated help textopenHTMLInBrowser()function inmain.gothat creates a temp HTML file and opens it with the system browserWhy?
Complex HTML emails are hard to read in the terminal's degraded text rendering. Opening them in a real browser makes them much easier to view with proper formatting, images, and styling intact. This is a beginner-friendly feature that solves the original issue of poor HTML email readability in TUI mode.
Fixes: #1150