Skip to content

Restore relay url logging for best bid message#899

Open
ncherkas wants to merge 2 commits into
flashbots:developfrom
bloXroute-Labs:fix-bid-received-log
Open

Restore relay url logging for best bid message#899
ncherkas wants to merge 2 commits into
flashbots:developfrom
bloXroute-Labs:fix-bid-received-log

Conversation

@ncherkas
Copy link
Copy Markdown

@ncherkas ncherkas commented Apr 17, 2026

📝 Summary

In 1.11 url attribute has been removed for bid received messages which makes it difficult to trace the received bids per slot. Please help to get it merged to restore this attribute in the logs.

⛱ Motivation and Context

📚 References


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

Copilot AI review requested due to automatic review settings April 17, 2026 13:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores relay URL context in bid received logging to help correlate bids with their originating relay (and slot context already present in the request logger).

Changes:

  • Adds a url field to the logger inside processBid so downstream log lines (e.g., bid received, new best bid) include relay URL context.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread server/get_header.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants