refactor: Make GestureDetectorBuilder and detector/callback registering more resilient#3900
Merged
luanpotter merged 4 commits intomainfrom Apr 27, 2026
Merged
refactor: Make GestureDetectorBuilder and detector/callback registering more resilient#3900luanpotter merged 4 commits intomainfrom
luanpotter merged 4 commits intomainfrom
Conversation
luanpotter
force-pushed
the
luan.recognizers
branch
2 times, most recently
from
26b9a08 to
f46ad2e
Compare
luanpotter
force-pushed
the
luan.recognizers
branch
from
f46ad2e to
0e0ab5a
Compare
spydon
reviewed
Apr 20, 2026
luanpotter
commented
Apr 25, 2026
| T Function() constructor, | ||
| void Function(T) initializer, | ||
| ) { | ||
| final count = _counters[T]; |
Member
Author
There was a problem hiding this comment.
we just have one dispatcher per gesture now, and it can be much better tracked on a single map
luanpotter
force-pushed
the
luan.recognizers
branch
from
5c2ad23 to
e977bf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make GestureDetectorBuilder and detector/callback registering more resilient wrt to multiple registrations (callbacks that use the same detector).
This extracts a base class to dispatchers to share code and remove reundancies.
It also makes the code on *Callbacks themselves trivial, and accounts for duplication.
Before different callbacks could duplicate dispatchers. Now we properly guarantee dispatchers are singleton while allowing callbacks to require and use the same dispatcher. This is important for tertiary callbacks which will use the same underlying dispatcher as secondary.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?