Auto-update dependencies.#295
Open
dpebot wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Android SDK configuration in app/build.gradle.kts by upgrading compileSdk and targetSdk to 37, and bumps the Firebase BoM version to 34.14.1. Feedback suggests reverting the SDK versions back to 36, as API level 37 is not yet stable or widely supported, which could lead to build failures.
Comment on lines
+9
to
+13
| compileSdk = 37 | ||
| defaultConfig { | ||
| applicationId = "com.google.firebase.example.fireeats" | ||
| minSdk = 23 | ||
| targetSdk = 36 | ||
| targetSdk = 37 |
There was a problem hiding this comment.
Upgrading compileSdk and targetSdk to 37 is premature as Android API level 37 is not yet a stable or widely released SDK version. This can cause build failures or compilation issues in environments where the SDK is not available. It is recommended to revert these to a stable or supported SDK version (such as 36 or 35).
compileSdk = 36
defaultConfig {
applicationId = "com.google.firebase.example.fireeats"
minSdk = 23
targetSdk = 36
dpebot
force-pushed
the
dpebot-repositorygardener
branch
2 times, most recently
from
bde3cfe to
0523c1e
Compare
dpebot
force-pushed
the
dpebot-repositorygardener
branch
from
0523c1e to
82fc518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought to you by your friendly Repository Gardener.