feat(mcp): add MCP-Protocol-Version, Mcp-Method, and Mcp-Name HTTP headers#10808
Merged
Conversation
…TTP headers to `OneMcpServer` ### Description Adds `MCP-Protocol-Version`, `Mcp-Method`, and `Mcp-Name` HTTP headers for proxy requests issued by `OneMcpServer`, adhering to the MCP 0728 standard release candidate specification and SEP-2243: - https://blog.modelcontextprotocol.io/posts/2026-07-28-release-candidate/ - https://modelcontextprotocol.io/seps/2243-http-standardization ### Scenarios Tested - Unit tests in src/mcp/onemcp/onemcp_server.spec.ts verifying listTools sends `MCP-Protocol-Version` and `Mcp-Method`. - Unit tests in src/mcp/onemcp/onemcp_server.spec.ts verifying callTool sends `MCP-Protocol-Version`, `Mcp-Method`, `Mcp-Name`, and `x-goog-user-project` headers. ### Sample Commands npx mocha --require ts-node/register src/mcp/onemcp/onemcp_server.spec.ts
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates OneMcpServer to include MCP-Protocol-Version, Mcp-Method, and Mcp-Name HTTP headers in its requests, aligning with the MCP 0728 standard. The reviewer feedback consistently recommends changing the casing of MCP-Protocol-Version to Mcp-Protocol-Version in the source code, unit tests, and changelog to maintain consistency and adhere to standard casing.
Comment on lines
+116
to
+121
| headers: { | ||
| "MCP-Protocol-Version": LATEST_PROTOCOL_VERSION, | ||
| "Mcp-Method": "tools/call", | ||
| "Mcp-Name": toolName, | ||
| ...(ctx.projectId ? { "x-goog-user-project": ctx.projectId } : {}), | ||
| }, |
Contributor
There was a problem hiding this comment.
For consistency with other MCP headers like Mcp-Method and Mcp-Name, and to align with the standard casing defined in SEP-2243, use Mcp-Protocol-Version instead of MCP-Protocol-Version.
Suggested change
| headers: { | |
| "MCP-Protocol-Version": LATEST_PROTOCOL_VERSION, | |
| "Mcp-Method": "tools/call", | |
| "Mcp-Name": toolName, | |
| ...(ctx.projectId ? { "x-goog-user-project": ctx.projectId } : {}), | |
| }, | |
| headers: { | |
| "Mcp-Protocol-Version": LATEST_PROTOCOL_VERSION, | |
| "Mcp-Method": "tools/call", | |
| "Mcp-Name": toolName, | |
| ...(ctx.projectId ? { "x-goog-user-project": ctx.projectId } : {}), | |
| }, |
Comment on lines
122
to
127
| expect(clientRequestStub.secondCall.args[0].headers).to.deep.include({ | ||
| "MCP-Protocol-Version": LATEST_PROTOCOL_VERSION, | ||
| "Mcp-Method": "tools/call", | ||
| "Mcp-Name": "test_tool", | ||
| "x-goog-user-project": "test-project", | ||
| }); |
Contributor
There was a problem hiding this comment.
Update the test assertion to use the consistent casing Mcp-Protocol-Version.
Suggested change
| expect(clientRequestStub.secondCall.args[0].headers).to.deep.include({ | |
| "MCP-Protocol-Version": LATEST_PROTOCOL_VERSION, | |
| "Mcp-Method": "tools/call", | |
| "Mcp-Name": "test_tool", | |
| "x-goog-user-project": "test-project", | |
| }); | |
| expect(clientRequestStub.secondCall.args[0].headers).to.deep.include({ | |
| "Mcp-Protocol-Version": LATEST_PROTOCOL_VERSION, | |
| "Mcp-Method": "tools/call", | |
| "Mcp-Name": "test_tool", | |
| "x-goog-user-project": "test-project", | |
| }); |
joehan
approved these changes
Jul 16, 2026
chkuang-g
enabled auto-merge (squash)
July 16, 2026 21:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
MCP-Protocol-Version,Mcp-Method, andMcp-NameHTTP headers for proxy requests issued byOneMcpServer, adhering to the MCP 0728 standard release candidate specification and SEP-2243:Scenarios Tested
MCP-Protocol-VersionandMcp-Method.MCP-Protocol-Version,Mcp-Method,Mcp-Name, andx-goog-user-projectheaders.Sample Commands
npx mocha --require ts-node/register src/mcp/onemcp/onemcp_server.spec.ts