fix: prevent duplicated UpdateFunction calls#10759
Open
IzaakGough wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request restricts retrying requests on premature close errors to specific HTTP methods by introducing a helper function, and adds corresponding unit tests. The review feedback correctly notes that the helper function is named isIdempotentMethod but includes POST, which is non-idempotent. It suggests renaming the function to shouldRetryMethod to maintain semantic correctness.
IzaakGough
marked this pull request as ready for review
July 3, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10731
Summary
Prevent Cloud Functions update requests from enabling the premature-close retry path, which could cause duplicate
UpdateFunctioncalls.Problem/Root Cause
PATCHupdate requests were eligible for the keep-alive retry path when a premature-close error occurred. For Cloud Functions updates, that could reissue the operation and produce duplicate update calls.Solution/Changes
Add a per-request
retryOnPrematureCloseflag to the API client and disable it for Cloud Functions v1 and v2 update calls. Update the request tests to cover both the disabled and default retry behavior.Testing
src/apiv2.spec.ts.