cleanup: remove experimental firebase app testing feature#10741
Open
jakeouellette wants to merge 3 commits into
Open
cleanup: remove experimental firebase app testing feature#10741jakeouellette wants to merge 3 commits into
jakeouellette wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request completely removes the experimental "App Testing" feature from the codebase. This includes deleting the apptesting command, its initialization logic, associated tests, templates, API origins, and the corresponding experiment flag. I have no feedback to provide.
jakeouellette
force-pushed
the
cleanup/remove-apptesting
branch
2 times, most recently
from
June 30, 2026 15:09
1fb8087 to
562acdb
Compare
### Description Removes all code, templates, tests, and CLI commands related to the Firebase App Testing (FAD) experiment, which has been turned down. Specifically, this: - Deletes the `apptesting` CLI commands: `apptesting.ts`, `apptesting-wata.ts`, and `apptesting.spec.ts`. - Deletes the `src/apptesting` logic, types, and unit tests. - Deletes `src/init/features/apptesting` and templates. - Removes all MCP apptesting integrations under `src/mcp` (prompts, tools, and utilities). - Removes references to the `apptesting` experiment, `SetupInfo` registration, and `firebase init` choices. - Cleans up `test:apptesting` from `package.json`. ### Scenarios Tested - Verified TypeScript compilation via `npm run test:compile`. - Ran unit tests via `npm run mocha:fast` and verified all 4530 tests passed.
jakeouellette
force-pushed
the
cleanup/remove-apptesting
branch
from
June 30, 2026 18:57
562acdb to
4af6cac
Compare
### Description Restores the `apptesting:execute` command, its parser logic (`parseTestFiles`), unit tests, and template configuration. These files were removed in the FAD cleanup commit, but they are needed to support the mobile App Distribution automated testing workflow (MATA/ATA). Web app testing agent (`apptesting-wata`) and its dependencies remain removed as intended. ### Scenarios Tested - Ran `npm run test:compile` (compiled with no errors). - Ran `npm run test:apptesting` and `npx mocha src/commands/apptesting.spec.ts` (all tests passed).
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes all code, templates, tests, and CLI commands related to the Firebase App Testing (FAD) experiment
Specifically, this:
apptestingCLI command undersrc/commands/apptesting-execute.ts.src/apptestinglogic, types, and unit tests.src/init/features/apptestingand the corresponding templatetemplates/init/apptesting/smoke_test.yaml.apptestingexperiment,SetupInforegistration, andfirebase initchoices.test:apptestingfrompackage.json.Scenarios Tested
npm run test:compile.npm run mocha:fastand verified all passed.