Skip to content

chore: add eslint-config-prettier#329

Merged
inlined merged 2 commits into
firebase:masterfrom
inlined:add-eslint-config-prettier
Jul 1, 2026
Merged

chore: add eslint-config-prettier#329
inlined merged 2 commits into
firebase:masterfrom
inlined:add-eslint-config-prettier

Conversation

@inlined

@inlined inlined commented Jun 30, 2026

Copy link
Copy Markdown
Member

This PR adds eslint-config-prettier to disable ESLint rules that conflict with Prettier, addressing post-merge feedback from #322.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates Prettier with ESLint by adding the eslint-config-prettier dependency to package.json and updating .eslintrc.json to extend the Prettier configuration. I have no feedback to provide as there are no review comments.

@inlined
inlined requested a review from shettyvarun268 June 30, 2026 20:41

@shettyvarun268 shettyvarun268 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Has another conflict that needs to be resolved

@inlined
inlined merged commit 97c9481 into firebase:master Jul 1, 2026
10 checks passed
@inlined
inlined deleted the add-eslint-config-prettier branch July 1, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants