Excessive allocations in Firebase Trace.incrementMetric#7984
Excessive allocations in Firebase Trace.incrementMetric#7984OOS93 wants to merge 4 commits intofirebase:mainfrom
Conversation
…disabled for better performance at Trace.incrementMetric.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
27f325a to
08355e0
Compare
Fixes:
#1923
Quick Summary:
Current PR addresses an optimization at PerfMetricValidator.validateTraceName(), it also gates the Metric logging after this validation succeed within Trace.incrementMetric() (allowing the log building if the flag is enabled) and optimizes this String building process (using String template instead of String.format).