Skip to content

Lots of improvements #43

Open
ceremcem wants to merge 25 commits into
fboender:masterfrom
ceremcem:master
Open

Lots of improvements #43
ceremcem wants to merge 25 commits into
fboender:masterfrom
ceremcem:master

Conversation

@ceremcem

@ceremcem ceremcem commented Jan 7, 2021

Copy link
Copy Markdown
  • Added tests
  • Added "stalled branch" detection
  • Added "only submodules" filter
  • Speedup
  • Covered "Repo has no commits yet" state

@solarchemist

Copy link
Copy Markdown

Support for git submodules would be awesome! Great work, hope it can be incorporated into mgitstatus.

@braydentraas

braydentraas commented Mar 15, 2021

Copy link
Copy Markdown

Git submodules is a must-have! Thanks for adding this support.

However, I have 2 issues:

  1. It doesn't work on ZSH: git config --file=.gitmodules --get-regexp ^^submodule.*\.path$ | cut -d " " -f 2 (can be fixed by wrapping the regex in quotes: "^^submodule.*\.path$")
  2. It doesn't work on macOS: find -L "$DIR" $FIND_OPTS -depth -name ".git" -printf "%h\0" (no -printf flag on BSD's find)

It worked great on Bash/Linux; I'm hoping this can be resolved and merged soon.

Cheers!

@ceremcem

Copy link
Copy Markdown
Author

@braydentraas Does gfind solve the issue on Mac: https://superuser.com/a/293200/187576?

@braydentraas

Copy link
Copy Markdown

@ceremcem Yes it does, but now readarray isn't available on mac/BSD either (or zsh even on linux)

@ceremcem

Copy link
Copy Markdown
Author

As I don't have Mac on hand, I'm not sure how to proceed here. Are you able to implement the necessary changes and test on Mac? (I even didn't know this repo has been supporting Mac)

@btraas

btraas commented Mar 16, 2021

Copy link
Copy Markdown

@ceremcem I've made a few changes and submitted a PR to your repo. Works for me now on MacOS/ZSH and Linux/Bash

Thanks again!

@aminya aminya mentioned this pull request May 14, 2022
@andrejpan

Copy link
Copy Markdown

Any idea why this is not yet merged?

@ceremcem

ceremcem commented Apr 8, 2024

Copy link
Copy Markdown
Author

Don't know.

@andrejpan

Copy link
Copy Markdown

@ceremcem thank you for your updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants