fix: memory safety issues in convertBodyInit#1504
Merged
Merged
Conversation
zkat
enabled auto-merge (squash)
July 17, 2026 17:11
zkat
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several memory safety issues in
convertBodyInitrelating to treating temporary buffers as owned. Specifically, the branches forArrayBuffer,ArrayBufferView, andURLSearchParamsall use the wrong buffer for the return value. This PR ensures the data is copied into an owned buffer, which is then used as the return value.There are no additional tests for this change because we lack sanitizer support.