Support union types#1719
Open
tylerriccio33 wants to merge 15 commits into
Open
Conversation
Author
|
Hey mate @tiangolo , anything I can do to move this along? Looking to incorporate typer into some work I have coming up :) |
Author
|
Hey @tiangolo any thoughts :) |
Author
|
Anything that can be done to move this along ? |
github-actions
Bot
added
the
conflicts
Contributor
|
This pull request has a merge conflict that needs to be resolved. |
github-actions
Bot
removed
the
conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1148
Original Comment:
_This PR adds the ability to use real unions (a la Union[int, str]), as requested in #461.
I am new to contributing to this Repository, and I'll happily add anything I might have missed (docs/tests/incorrect code location/etc)._
I didn't really add anything new aside from more tests, and the bugs called out in the comment section. If this is in line with what you're thinking, I can add more tests and update documentation! This would help me a lot at work, I could use Typer more.