Make TaskGroup.__aexit__ return Literal[False]#472
Open
eitan-protego wants to merge 7 commits into
Open
Conversation
Defining TaskGroup.__aexit__ explicitly always return False allows type checkers to safely assume that all code inside of it ran to completion without swallowing exceptions. This in turn prevents type errors about variables defined inside the `async with` block being possibly undefined.
github-actions
Bot
added
the
conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
Bot
removed
the
conflicts
Author
|
@tiangolo I'd appreciate if you'd review this and let me know if you're inclined to accept it (or if I'm missing something and in fact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defining
TaskGroup.__aexit__explicitly always return False allows type checkers to safely assume that all code inside of it ran to completion without swallowing exceptions. This in turn prevents type errors about variables defined inside theasync withblock being possibly undefined.