Implement RBAC message discarding filters#407
Open
magnusg-kdab wants to merge 2 commits into
Open
Conversation
magnusg-kdab
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
magnusg-kdab
had a problem deploying
to
configure coverage
GitHub Actions
Failure
magnusg-kdab
had a problem deploying
to
configure coverage
GitHub Actions
Failure
magnusg-kdab
had a problem deploying
to
configure coverage
GitHub Actions
Failure
magnusg-kdab
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
magnusg-kdab
had a problem deploying
to
configure coverage
GitHub Actions
Failure
magnusg-kdab
force-pushed
the
rbacfilters
branch
from
8f4fb7a to
6c212ff
Compare
magnusg-kdab
had a problem deploying
to
configure coverage
GitHub Actions
Failure
magnusg-kdab
had a problem deploying
to
configure coverage
GitHub Actions
Error
magnusg-kdab
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
magnusg-kdab
had a problem deploying
to
configure coverage
GitHub Actions
Failure
magnusg-kdab
had a problem deploying
to
configure coverage
GitHub Actions
Failure
magnusg-kdab
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
A missing trailing slash caused opencmw::URI to return no path. The best solution would be to add a fallback "/" root path to opencmw::URI, in case no path is present. However, this would trigger the assert in URI::returnOpt that checks if the returned string is part of the original provided string. Therefore we opt for this less invasive change. Signed-off-by: Magnus Groß <magnus.gross+github@kdab.com>
Signed-off-by: Magnus Groß <magnus.gross+github@kdab.com>
magnusg-kdab
force-pushed
the
rbacfilters
branch
from
6c212ff to
73a842c
Compare
magnusg-kdab
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
magnusg-kdab
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
magnusg-kdab
had a problem deploying
to
configure coverage
GitHub Actions
Failure
magnusg-kdab
had a problem deploying
to
configure coverage
GitHub Actions
Failure
magnusg-kdab
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be flexible with the message discarding, this uses a generic predicate to be able to configure the discarding rules.
Closes #403