Skip to content

Fix formatter: exclude basic_string(_view) from FormattableRange to s…#400

Merged
wirew0rm merged 1 commit into
mainfrom
fixGrJoin
Feb 16, 2026
Merged

Fix formatter: exclude basic_string(_view) from FormattableRange to s…#400
wirew0rm merged 1 commit into
mainfrom
fixGrJoin

Conversation

@drslebedev

@drslebedev drslebedev commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

Fix formatter: exclude basic_string(_view) from FormattableRange to support pmr::string

  • Avoids clang/libc++ formatterstd::pmr::string ambiguity
  • gr::join(std::vectorstd::pmr::string) becomes valid again, no longer ambiguous element formatting.

@drslebedev
drslebedev marked this pull request as draft February 16, 2026 13:24
@drslebedev
drslebedev temporarily deployed to configure coverage February 16, 2026 13:24 — with GitHub Actions Inactive
@drslebedev
drslebedev temporarily deployed to configure coverage February 16, 2026 13:24 — with GitHub Actions Inactive
@drslebedev
drslebedev temporarily deployed to configure coverage February 16, 2026 13:24 — with GitHub Actions Inactive
@drslebedev
drslebedev temporarily deployed to configure coverage February 16, 2026 13:24 — with GitHub Actions Inactive
@drslebedev
drslebedev temporarily deployed to configure coverage February 16, 2026 13:24 — with GitHub Actions Inactive
@drslebedev
drslebedev marked this pull request as ready for review February 16, 2026 13:49
@drslebedev
Fix formatter: exclude basic_string(_view) from FormattableRange to s…
793f202 
…upport pmr::string

* Avoids clang/libc++ formatter<std::pmr::string> ambiguity
* gr::join(std::vector<std::pmr::string>) becomes valid again, no longer ambiguous element formatting.

Signed-off-by: drslebedev <dr.s.lebedev@gmail.com>
@drslebedev
drslebedev temporarily deployed to configure coverage February 16, 2026 14:07 — with GitHub Actions Inactive
@drslebedev
drslebedev temporarily deployed to configure coverage February 16, 2026 14:07 — with GitHub Actions Inactive
@drslebedev
drslebedev temporarily deployed to configure coverage February 16, 2026 14:07 — with GitHub Actions Inactive
@drslebedev
drslebedev temporarily deployed to configure coverage February 16, 2026 14:07 — with GitHub Actions Inactive
@drslebedev
drslebedev temporarily deployed to configure coverage February 16, 2026 14:07 — with GitHub Actions Inactive
@drslebedev
drslebedev temporarily deployed to configure coverage February 16, 2026 14:07 — with GitHub Actions Inactive
@sonarqubecloud

sonarqubecloud Bot commented Feb 16, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wirew0rm
wirew0rm merged commit 4962c28 into main Feb 16, 2026
11 checks passed
@wirew0rm
wirew0rm deleted the fixGrJoin branch February 16, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wirew0rm wirew0rm wirew0rm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drslebedev @wirew0rm