Don't override explicitly requested TL model class (#5183)#5183
Closed
hvarfner wants to merge 1 commit intofacebook:mainfrom
Closed
Don't override explicitly requested TL model class (#5183)#5183hvarfner wants to merge 1 commit intofacebook:mainfrom
hvarfner wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@hvarfner has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101174566. |
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 21, 2026
…ing_gs (facebook#5183) Summary: When the source and target search spaces are incompatible, `get_transfer_learning_gs` silently overrides the model class to `HeterogeneousMTGP`. This prevents using `ImputedMultiTaskGP` or other heterogeneous-aware model classes that the caller explicitly requested. Only override to `HeterogeneousMTGP` when the caller passed the default `MultiTaskGP`. If a different model class was explicitly requested, respect it. Differential Revision: D101174566
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 21, 2026
…ing_gs (facebook#5183) Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Differential Revision: D101174566
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 21, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Differential Revision: D101174566
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 21, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Differential Revision: D101174566
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 21, 2026
…ing_gs (facebook#5183) Summary: Pull Request resolved: facebook#5183 When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Differential Revision: D101174566
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 22, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
meta-codesync
Bot
changed the title
hvarfner
force-pushed
the
export-D101174566
branch
from
aaa839d to
5a8da98
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 23, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
5a8da98 to
9f13a2f
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 23, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
9f13a2f to
31aedea
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 23, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
31aedea to
201b91e
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 23, 2026
Summary: Pull Request resolved: facebook#5183 When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
201b91e to
effb38e
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 24, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
effb38e to
88a3e29
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5183 +/- ##
==========================================
- Coverage 96.43% 96.42% -0.02%
==========================================
Files 617 617
Lines 69379 69398 +19
==========================================
+ Hits 66908 66918 +10
- Misses 2471 2480 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 24, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
88a3e29 to
3ca2bf0
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 24, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
3ca2bf0 to
b2b7a0a
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: facebook#5183 When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
b2b7a0a to
d852e7a
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 24, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
d852e7a to
3813b94
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 24, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
3813b94 to
81e0ce3
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 24, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
81e0ce3 to
e4a3800
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: facebook#5183 When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
e4a3800 to
e5f9508
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Apr 24, 2026
Summary: When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
e5f9508 to
1172f3a
Compare
Summary: Pull Request resolved: facebook#5183 When the source and target search spaces are incompatible, any model class is silently overridden to `HeterogeneousMTGP`. This prevents using other models at all. Now, we only override to `HeterogeneousMTGP` in get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it. Reviewed By: sdaulton Differential Revision: D101174566
hvarfner
force-pushed
the
export-D101174566
branch
from
1172f3a to
3c86c96
Compare
|
This pull request has been merged in ebad6c1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When the source and target search spaces are incompatible,
any model class is silently overridden to
HeterogeneousMTGP. This prevents using other models at all.Now, we only override to
HeterogeneousMTGPin get_transfer_learning_gs, instead of in two different places in the stack. Thus, we will still have the same functionality but not double-force it.Reviewed By: sdaulton
Differential Revision: D101174566