Skip to content

bump Lean version to 4.29.0, the current stable version#171

Merged
oxe-i merged 1 commit intoexercism:mainfrom
oxe-i:bumpVersion
Apr 7, 2026
Merged

bump Lean version to 4.29.0, the current stable version#171
oxe-i merged 1 commit intoexercism:mainfrom
oxe-i:bumpVersion

Conversation

@oxe-i
Copy link
Copy Markdown
Contributor

@oxe-i oxe-i commented Apr 7, 2026

Bumps Lean version from 4.25.2 to 4.29.0, which is the current stable version.

In order to make this process as sane as possible, I've made the following changes:

  1. Changed the generator script so that -r (regenerate) now copies the toolchain in templates/lean-toolchain to each exercise. This ensures they are synchronized and also makes it much easier to bump the toolchain version for all exercises, by just changing the template toolchain.
  2. While at it, I also improved the messages to indicate the exercise being currently generated, in order to make it possible to act on it in case of an error.
  3. Bumped the version for the generator script too, so that we don't need to maintain two different toolchains.
  4. Added --wfail to both bin/run-generator and bin/verify-exercises, so that any warning is treated as an error.
  5. Changed the generator script and all other files (test generators and example solutions) that reported an error. I think most of them were due to changes in the String API functions. For example, List.asString being deprecated in favor of String.ofList. However, there were two example solutions that needed a deeper rework: word-count and wordy.
  6. Found and fixed a bug in the generator script for nucleotide-count. I was extracting the expected counts even in case of a test case where the result was an error and not a valid count.

I'll bump the version in the test-runner next.

@keiravillekode keiravillekode added the x:rep/large Large amount of reputation label Apr 7, 2026
Copy link
Copy Markdown
Contributor

@keiravillekode keiravillekode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to merge around the same time the test runner PR is merged.

@oxe-i oxe-i merged commit 2cd38cf into exercism:main Apr 7, 2026
7 checks passed
@oxe-i oxe-i deleted the bumpVersion branch April 7, 2026 22:12
@keiravillekode
Copy link
Copy Markdown
Contributor

We should post an update in https://forum.exercism.org/t/string-split-and-acronym/36697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:rep/large Large amount of reputation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants