bump Lean version to 4.29.0, the current stable version#171
Merged
oxe-i merged 1 commit intoexercism:mainfrom Apr 7, 2026
Merged
bump Lean version to 4.29.0, the current stable version#171oxe-i merged 1 commit intoexercism:mainfrom
oxe-i merged 1 commit intoexercism:mainfrom
Conversation
keiravillekode
approved these changes
Apr 7, 2026
Contributor
keiravillekode
left a comment
There was a problem hiding this comment.
Approved to merge around the same time the test runner PR is merged.
Contributor
|
We should post an update in https://forum.exercism.org/t/string-split-and-acronym/36697 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Lean version from 4.25.2 to 4.29.0, which is the current stable version.
In order to make this process as sane as possible, I've made the following changes:
-r(regenerate) now copies the toolchain intemplates/lean-toolchainto each exercise. This ensures they are synchronized and also makes it much easier to bump the toolchain version for all exercises, by just changing the template toolchain.--wfailto bothbin/run-generatorandbin/verify-exercises, so that any warning is treated as an error.StringAPI functions. For example,List.asStringbeing deprecated in favor ofString.ofList. However, there were two example solutions that needed a deeper rework:word-countandwordy.nucleotide-count. I was extracting the expected counts even in case of a test case where the result was an error and not a valid count.I'll bump the version in the test-runner next.