Bugfix/563 fix merge gate#819
Open
ArBridgeman wants to merge 5 commits intomainfrom
Open
Conversation
kratz00
previously approved these changes
May 5, 2026
tomuben
reviewed
May 5, 2026
Comment on lines
+73
to
+75
| - name: Branch Protection - failure if any ancestor failed | ||
| if: ${{ contains(needs.*.result, 'failure') }} | ||
| run: exit 1 |
Contributor
There was a problem hiding this comment.
Hm, does this really work. Because in happy day scenario, no step would be executed at all....
Collaborator
There was a problem hiding this comment.
That was what we did in ai-lab, the difference is the if: ${{ !cancelled() }} and the two paths for failure and else
gate-2:
if: ${{ !cancelled() }}
name: Gate 2 - Allow Merge
runs-on: ubuntu-24.04
needs: [ run-unit-tests, run-integration-tests, run-stable-notebook-tests, run-stable-gpu-notebook-tests ]
steps:
- name: Branch Protection - failure if any ancestor failed
if: ${{ contains(needs.*.result, 'failure') }}
run: |
echo '${{ toJSON(needs) }}'
exit 1
- name: Branch Protection
run: true
Collaborator
Author
There was a problem hiding this comment.
Ah, thanks. Yeah, I wasn't sure from what was written what was critical or not.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



closes #563
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: