Skip to content

Bugfix/563 fix merge gate#819

Open
ArBridgeman wants to merge 5 commits intomainfrom
bugfix/563_fix_merge_gate
Open

Bugfix/563 fix merge gate#819
ArBridgeman wants to merge 5 commits intomainfrom
bugfix/563_fix_merge_gate

Conversation

@ArBridgeman
Copy link
Copy Markdown
Collaborator

@ArBridgeman ArBridgeman commented May 5, 2026

closes #563

Checklist

Note: If any of the items in the checklist are not relevant to your PR, just check the box.

For any Pull Request

Is the following correct:

  • the title of the Pull Request?
  • the title of the corresponding issue?
  • there are no other open Pull Requests for the same update/change?
  • that the issue which this Pull Request fixes ("Fixes...") is mentioned?

When Changes Were Made

Did you:

  • update the changelog?
  • update the cookiecutter-template?
  • update the implementation?
  • check coverage and add tests: unit tests and, if relevant, integration tests?
  • update the User Guide & other documentation?
  • resolve any failing CI criteria (incl. Sonar quality gate)?

When Preparing a Release

Have you:

  • thought about version number (major, minor, patch)?
  • checked Exasol packages for updates and resolved open vulnerabilities, if easily possible?

@ArBridgeman ArBridgeman temporarily deployed to manual-approval May 5, 2026 12:10 — with GitHub Actions Inactive
@ArBridgeman ArBridgeman marked this pull request as ready for review May 5, 2026 12:14
kratz00
kratz00 previously approved these changes May 5, 2026
Comment on lines +73 to +75
- name: Branch Protection - failure if any ancestor failed
if: ${{ contains(needs.*.result, 'failure') }}
run: exit 1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, does this really work. Because in happy day scenario, no step would be executed at all....

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was what we did in ai-lab, the difference is the if: ${{ !cancelled() }} and the two paths for failure and else

  gate-2:
    if: ${{ !cancelled() }}
    name: Gate 2 - Allow Merge
    runs-on: ubuntu-24.04
    needs: [ run-unit-tests, run-integration-tests, run-stable-notebook-tests, run-stable-gpu-notebook-tests ]
    steps:
      - name: Branch Protection - failure if any ancestor failed
        if: ${{ contains(needs.*.result, 'failure') }}
        run: |
          echo '${{ toJSON(needs) }}'
          exit 1
      - name: Branch Protection
        run: true

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks. Yeah, I wasn't sure from what was written what was critical or not.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge Gate not working

4 participants