fix: typing, recording-audio & reactions silently dropped (canonical JID)

[joaoporth]

Closes #63

What

Fix three WhatsApp features that returned 200 but never reached the recipient:

• Typing (digitando...) and recording-audio (gravando áudio...) on POST /message/presence
• Reactions on POST /message/react
• Read receipts on POST /message/markread

…plus a delay option to sustain the typing/recording indicator.

Root cause

utils.CreateJID/ParseJID intentionally prefix phone numbers with + (e.g. +5541...@s.whatsapp.net) for the IsOnWhatsApp/display convention. Message sending tolerates this because whatsmeow normalizes the JID during usync/device resolution.

But several features send RAW nodes without usync, where the malformed +JID survives:

• chatstate (typing/recording) — the node went out with to="+5541...@s.whatsapp.net", which WhatsApp does not route, so the indicator never appeared. Verified at the wire level.
• reaction — the +JID is used both as the SendMessage target (can stall device resolution → usync timeout) and as the MessageKey.RemoteJID that references the reacted message's chat; a +-prefixed chat doesn't match the real chat, so the reaction never attaches to the message.
• read receipts — same RAW-node issue.

Changes

• utils.CanonicalJID — strips the leading + so RAW-node targets are canonical, digits-only WhatsApp JIDs. Covered by TestCanonicalJID.
• Apply it in ChatPresence (typing/recording), React (recipient + group participant) and MarkRead (read receipts).
• SendPresence(available) before the chatstate — WhatsApp only forwards chatstate while the sender is marked online; background presence handling can leave the client Unavailable, dropping the indicator.
• delay (ms) on /message/presence — keeps the indicator alive for the requested duration (re-sending every 5s, capped at 60s) then sends paused, instead of a single ephemeral fire.

Testing

End-to-end on a live instance, confirmed on the recipient device:

• ✅ digitando... and gravando áudio... appear (and persist for delay).
• ✅ Reactions attach to the correct message, including multi-codepoint emoji (❤️), with no usync timeout.
• ✅ go build, go vet, go test ./pkg/utils/ all green.

Examples

POST /message/presence
{ "number": "5541...", "state": "composing", "isAudio": false, "delay": 8000 }

POST /message/react
{ "number": "5541...", "id": "3EB0...", "reaction": "👍", "fromMe": true }

isAudio: true → gravando áudio.... delay omitted/0 → legacy single-fire (unchanged).

🤖 Generated with Claude Code

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes WhatsApp reaction handling so that reactions are sent with a fresh envelope ID while still targeting the original message, preventing WhatsApp from silently deduplicating and dropping reactions, and ensures the stored message record uses the actual reaction envelope ID returned by the server.

Sequence diagram for updated WhatsApp reaction sending in React

sequenceDiagram
    participant Caller as Caller
    participant MessageService as messageService
    participant WhatsmeowClient as whatsmeowClient
    participant WhatsAppServer as WhatsApp
    participant DB as MessageStore

    Caller->>MessageService: React(data, instance)
    MessageService->>MessageService: Build MessageKey using msgId
    MessageService->>MessageService: Build waE2E.Message with ReactionMessage
    MessageService->>WhatsmeowClient: SendMessage(ctx, recipient, msg)
    WhatsmeowClient->>WhatsAppServer: Send reaction with new envelope ID
    WhatsAppServer-->>WhatsmeowClient: SendMessage response(ID, ServerID)
    WhatsmeowClient-->>MessageService: response
    MessageService->>DB: Store message with ID = response.ID
    MessageService-->>Caller: ReactResponse

Loading

File-Level Changes

Change	Details	Files
Correct reaction message envelope ID handling to avoid silent drops and persist the real server-assigned ID.	Clarified that msgId refers to the target message being reacted to when creating the MessageKey, not the reaction envelope itself. Removed explicit ID: msgId from SendRequestExtra so whatsmeow can generate a unique reaction envelope ID, preventing deduplication by WhatsApp. Updated local persistence to store response.ID (the reaction envelope ID) instead of reusing msgId for the reaction record.	pkg/message/service/message_service.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates reaction sending to avoid ID reuse so WhatsApp doesn’t deduplicate/drop reactions.

Changes:

• Clarified that the MessageKey should reference the original message ID, not the reaction envelope ID.
• Stopped passing SendRequestExtra{ID: msgId} so whatsmeow generates a fresh envelope ID.
• Persisted the returned envelope ID (response.ID) instead of the original message ID (msgId).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[joaoporth]

Fechando este PR. Após testes mais aprofundados, as correções não se sustentaram: a mudança de presence (SendPresence available + chatstate) envia os nós corretamente no protocolo, mas o indicador de "digitando..." não aparece de fato para o destinatário em nossos testes, e a correção de React não pôde ser validada (usync timeout impediu o teste). Vou revisar e reabrir/abrir um novo PR quando estiver realmente validado. Obrigado!

[joaoporth]

Reabrindo: a causa-raiz foi identificada e corrigida. O chatstate (typing/recording) era enviado para um JID com prefixo + (malformado para nós RAW que não passam por usync), então o servidor não roteava. Com utils.CanonicalJID (strip do +) + SendPresence(available) antes do chatstate, os indicadores digitando... e gravando áudio... foram confirmados aparecendo no aparelho do destinatário em teste end-to-end. Também adicionado delay opcional para sustentar o indicador. Detalhes no corpo atualizado do PR.

[joaoporth]

Atualização: além dos indicadores de presença (digitando/gravando áudio), este PR agora também corrige as reações (/message/react) — mesma causa-raiz do + no JID. No React o JID malformado era usado tanto no SendMessage (resolução de devices/usync) quanto no MessageKey.RemoteJID que referencia o chat da mensagem reagida, então a reação não casava com a mensagem. Corrigido com utils.CanonicalJID. Testado end-to-end: reações (inclusive emoji multi-codepoint como ❤️) confirmadas grudando na mensagem certa, sem usync timeout.