Test against maintained Ruby versions (3.3, 3.4, 4.0)#56
Open
matt-evervault wants to merge 3 commits into
Open
Test against maintained Ruby versions (3.3, 3.4, 4.0)#56matt-evervault wants to merge 3 commits into
matt-evervault wants to merge 3 commits into
Conversation
The previous matrix tested 3.0, 3.1, 3.2 — all now EOL (3.0 in Apr 2024, 3.1 in Mar 2025, 3.2 in Mar 2026). It also had a latent bug: the unquoted `3.0` was parsed by YAML as the float 3.0 and collapsed to "3", so that job actually ran the latest 3.x rather than 3.0. Quote the versions and target the currently-maintained releases. Raise required_ruby_version to >= 3.3.0 to match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The previous matrix tested 3.0, 3.1, 3.2 — all now EOL (3.0 in Apr 2024, 3.1 in Mar 2025, 3.2 in Mar 2026). It also had a latent bug: the unquoted `3.0` was parsed by YAML as the float 3.0 and collapsed to "3", so that job actually ran the latest 3.x rather than 3.0. Quote the versions and target the currently-maintained stable releases (3.3, 3.4). Raise required_ruby_version to >= 3.3.0 to match. 3.5 is still only available as a preview, so it is left out until it has a stable release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
matt-evervault
changed the title
Ruby 4.0 is the current stable release line. Testing it requires bumping rake off the old ~> 12.0 pin: rake 12.3.3 requires ostruct, which is no longer a default gem in Ruby 3.5+, so `bundle exec rake` failed to load. rake 13.x dropped that dependency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
matt-evervault
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the CI test matrix and gemspec to target currently-maintained Ruby versions.
run-tests.yml,e2e.yml):3.0, 3.1, 3.2→3.3, 3.4, 4.0required_ruby_version:>= 3.0.0→>= 3.3.0rake:~> 12.0→~> 13.0Why
The previous matrix tested only EOL Ruby versions:
It also had a latent bug: the unquoted
3.0is parsed by YAML as the float3.0, which collapses to"3", sosetup-rubyinstalled the latest 3.x instead of 3.0 — the job never actually tested the declared minimum. Versions are now quoted so they mean what they say.Per maintainer guidance, dropping EOL versions is acceptable — consumers should not be on these.
required_ruby_versionis raised to match the tested floor.rake bump
Testing Ruby 4.0 (and any 3.5+) required moving off the old
rake ~> 12.0pin:rake 12.3.3requiresostruct, which is no longer a default gem in Ruby 3.5+, sobundle exec rakefailed to load withcannot load such file -- ostruct.rake 13.xdropped that dependency. Verified locally on Ruby 4.0.5: 66 examples, 0 failures.Why not 3.5?
setup-rubycurrently resolves3.5to3.5.0-preview1— there's no stable release on that line;4.0is the stable release after 3.4.Note
Follow-up to #54, which fixed the immediate CI failures (missing
base64dependency on Ruby 3.4+ and RuboCop offenses).🤖 Generated with Claude Code