feat: add unit flag for cheque deposit and withraw#686
Open
feat: add unit flag for cheque deposit and withraw#686
Conversation
Cafe137
reviewed
Apr 27, 2026
Comment on lines
19
to
21
| minimum: BigInt(1), | ||
| }) | ||
| public amount!: bigint |
Collaborator
There was a problem hiding this comment.
This probably needs to have type string
With type bigint it probably won't accept decimal values such as 0.5 (truncates to 0, invalid) or 1.5 (loses decimal part)
Cafe137
reviewed
Apr 27, 2026
Comment on lines
15
to
19
| key: 'amount', | ||
| type: 'bigint', | ||
| description: 'Amount of tokens to withdraw in PLUR', | ||
| description: 'Amount of tokens to withdraw', | ||
| required: true, | ||
| minimum: BigInt(1), |
Collaborator
There was a problem hiding this comment.
This probably needs to have type string
With type bigint it probably won't accept decimal values such as 0.5 (truncates to 0, invalid) or 1.5 (loses decimal part)
Cafe137
requested changes
Apr 27, 2026
Collaborator
|
Please check manually with decimal values. For example try depositing 0.5 BZZ to the chequebook and then withdrawing it back to the node wallet. |
…heque-deposit-and-cheque-withdraw-commands
Contributor
|
…-and-cheque-withdraw-commands' of github.com:ethersphere/swarm-cli into feat/it-is-hard-to-specify-bzz-amount-in-cheque-deposit-and-cheque-withdraw-commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new flag called
--unitfor cheque deposit and withdraw command, which the user can use to pick between bzz and plur, when specifying amount