added an example to switch LED using ESP8266WebServer#8590
Open
nsisong wants to merge 2 commits intoesp8266:masterfrom
Open
added an example to switch LED using ESP8266WebServer#8590nsisong wants to merge 2 commits intoesp8266:masterfrom
nsisong wants to merge 2 commits intoesp8266:masterfrom
Conversation
Collaborator
|
We do have a lot of LED switching already though, check out PostServer & AdvancedWebServer Also... instead of String, please use PROGMEM'ed strings ( |
Contributor
|
Why changing led pin state in main loop function? You end up with unnecessary digitalWrite call on each loop ;) Anyway, you should consider adding delay(1) or yield in your loop function. Not sure, maybe http server does that already. This will prevent watchdog related issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.