HTTP Client method for specifying whole authorization data#4404
Open
mortee wants to merge 5 commits intoesp8266:masterfrom
Open
HTTP Client method for specifying whole authorization data#4404mortee wants to merge 5 commits intoesp8266:masterfrom
mortee wants to merge 5 commits intoesp8266:masterfrom
Conversation
added 4 commits
February 20, 2018 16:55
…e Pushetta's (non-standard?) "Token <token>" scheme
…e Pushetta's (non-standard?) "Token <token>" scheme
This was referenced Apr 28, 2019
earlephilhower
added
the
merge-conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If already there is a separate method for specifying the base64-encoded data for basic auth, then it would be nice to allow for specifying the whole auth header. Right now, I'm using this to send request to pushetta.com's API, which needs a different kind of auth data (Token {your-auth-token}). Sure, I could simply set the header itself instead - but then again, that could be done for basic auth with pre-encoded data, too.