Adding onBefore()#2651
Open
holgerlembke wants to merge 1 commit intoesp8266:masterfrom
holgerlembke:webserver-onbefore
Open
Adding onBefore()#2651holgerlembke wants to merge 1 commit intoesp8266:masterfrom holgerlembke:webserver-onbefore
holgerlembke wants to merge 1 commit intoesp8266:masterfrom
holgerlembke:webserver-onbefore
Conversation
ith adding a onBefore() it is easy to block/grant access, log requests, verify data etc. for any on()-webrequest.
bool AllowWebServerAccess() {
HTTPMethod m = webserver->method();
if (m == HTTP_POST) {
if (webserver->client().remoteIP().toString().startsWith("192.168.")) {
return true;
} else {
Serial.print("Access blocked to ");
return false;
}
} else {
return true;
}
// paranoid.
return false;
}
Current coverage is 27.80% (diff: 100%)@@ master #2651 diff @@
==========================================
Files 20 20
Lines 3625 3625
Methods 335 335
Messages 0 0
Branches 656 656
==========================================
Hits 1008 1008
Misses 2441 2441
Partials 176 176
|
earlephilhower
added
merge-conflict
Collaborator
|
Thanks for your PR, but the core and libraries have changed enough that this PR now has a merge conflict. Could you merge it manually with the latest core, so we can consider it for future releases? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ith adding a onBefore() it is easy to block/grant access, log requests, verify data etc. for any on()-webrequest.
bool AllowWebServerAccess() {
HTTPMethod m = webserver->method();
if (m == HTTP_POST) {
if (webserver->client().remoteIP().toString().startsWith("192.168.")) {
return true;
} else {
Serial.print("Access blocked to ");
return false;
}
} else {
return true;
}
// paranoid.
return false;
}