Skip to content

Handle scanner POSTs to catch-all routes as not found#117

Closed
kentcdodds wants to merge 3 commits into
mainfrom
cleanup-sentry-internal-router-error-noise
Closed

Handle scanner POSTs to catch-all routes as not found#117
kentcdodds wants to merge 3 commits into
mainfrom
cleanup-sentry-internal-router-error-noise

Conversation

@kentcdodds
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds commented May 17, 2026

Summary

  • Patch the deployed epicshop workshop runtime after install so the root routes/$ module has an action that returns the same 404 behavior as its loader.
  • Update the not-found splat route solution and exercise copy to handle non-GET missing-route requests as 404s.
  • Add focused coverage for POSTs to scanner-style missing paths and for the runtime patcher.
  • Refresh the existing not-found exercise smoke assertion to match the page’s current Epic Notes heading.

Sentry

  • References epicshop Sentry issue EPICSHOP-F0 / 7447885629.
  • Targets noisy getInternalRouterError events from scanner POSTs like /connectors/resource/index.php and /assets/components/gallery/connector.php without suppressing unrelated router errors.

Validation

  • npm test in epicshop passes.
  • npm run typecheck passes.
  • npm test -- --project=chromium tests/e2e/smoke.test.ts in exercises/07.error-handling/05.solution.not-found passes.
Open in Web Open in Cursor 

cursoragent and others added 3 commits May 17, 2026 14:16
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@kody-bot kody-bot closed this May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants