Fixes for my dumper#12
Open
marcepartment wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Magento 2 mydumper/myloader wrapper commands to connect as the MySQL root user (to ensure sufficient privileges for consistent dumps and full-privilege restores), and bumps the project version accordingly.
Changes:
- Bump version from
0.7.0.3to0.7.0.4. - Switch
commands/magento2/mydumper.cmdto useroot/${MYSQL_ROOT_PASSWORD}and add explanatory comments. - Switch
commands/magento2/myloader.cmdto useroot/${MYSQL_ROOT_PASSWORD}and add explanatory comments.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
version |
Version bump to reflect the changes. |
commands/magento2/myloader.cmd |
Use root credentials for loads to ensure sufficient privileges. |
commands/magento2/mydumper.cmd |
Use root credentials for consistent dumps; adds rationale comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+46
to
50
| ## connect as root: a consistent dump needs the RELOAD/BACKUP_ADMIN privilege | ||
| ## (BACKUP STAGE START / FLUSH TABLES), which the limited app user lacks | ||
| MYDUMPER_ARGS=(--host=db --user=root --password="${MYSQL_ROOT_PASSWORD}") | ||
| [[ ${HAS_DATABASE} -eq 0 ]] && MYDUMPER_ARGS+=(--database="${MYSQL_DATABASE}") | ||
| [[ ${HAS_OUTPUT} -eq 0 ]] && MYDUMPER_ARGS+=(--outputdir="${MYDUMPER_OUTPUT_DIR}") |
Comment on lines
+48
to
52
| ## connect as root so the load has full privileges on the target schema | ||
| MYLOADER_ARGS=(--host=db --user=root --password="${MYSQL_ROOT_PASSWORD}") | ||
| [[ ${HAS_DATABASE} -eq 0 ]] && MYLOADER_ARGS+=(--database="${MYSQL_DATABASE}") | ||
| [[ ${HAS_DIRECTORY} -eq 0 ]] && MYLOADER_ARGS+=(--directory="${MYLOADER_INPUT_DIR}") | ||
| [[ ${HAS_OVERWRITE} -eq 0 ]] && MYLOADER_ARGS+=(--overwrite-tables) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.