Pytorch firing parity#5
Open
williamnourse wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered sources of firing rate discrepancy in PyTorch backend when compared to Brian2. Discrepancies were as follows:
New firing rate statistics compared to ground truth are as follows, based on t_run = 10.0 and n_run = 1:
Ground truth: Brian2 (CPU)
Brian2 (CPU): 168,903 spikes, 437 active neurons
PyTorch (CUDA) (Original Version):
Spikes: 95,052 (ratio: 0.5628)
Active: 380 (Jaccard: 0.8442, shared: 374, gt_only: 63, backend_only: 6)
Rate corr: 0.961903
Median diff: 47.45%
Verdict: CLOSE
PyTorch (CUDA) (Poisson inputs -> membrane):
Spikes: 174,681 (ratio: 1.0342)
Active: 437 (Jaccard: 0.9729, shared: 431, gt_only: 6, backend_only: 6)
Rate corr: 0.999439
Median diff: 5.06%
Verdict: MATCH
PyTorch (CUDA) (Poisson inputs -> membrane, Poisson inputs X refrafctory period):
Spikes: 172,730 (ratio: 1.0227)
Active: 435 (Jaccard: 0.9684, shared: 429, gt_only: 8, backend_only: 6)
Rate corr: 0.99947
Median diff: 3.62%
Verdict: MATCH