Fix/120 case insensitive repo removal#121
Open
enjoyandlove wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where removing a GitHub repository via webhook could silently fail if the repo name was stored with different casing than what the webhook payload sent. Two changes:
repoFullNameis now normalized to lowercase before insert, so all new rows are stored consistently.UPDATEquery now usesLOWER(repo_full_name) = LOWER(:name)viacreateQueryBuilder, making the lookup case-insensitive and matching rows regardless of how they were originally stored.Related Issues
Fixes #120
Type of Change
Testing
Org/Repo) is correctly matched and cleared when the webhook sendsorg/repo(all lowercase) or any other casing variant.Checklist